PomoBar

Fixed

• Fixed test accessor bug in timer state management where wrong variable was checked in type validation.
• Added null check for vault adapter to prevent runtime errors when loading custom audio files.
• Removed debug console.log statement from timer interval cleanup.
• Added error handling for audio playback failures to gracefully handle autoplay policy and format issues.
• Fixed audio overlap issue by stopping currently playing audio before starting new sound.
• Corrected volume slider description to match actual value range (0-1 instead of 0-100%).
• Removed dead/commented CSS style.
• Simplified volume preview sound logic for better readability.
• Fixed TypeScript build errors in test helpers:
  • Added missing App export to test setup file
  • Resolved Jest mock type issues by switching from type casting to jest.spyOn() approach
  • Fixed "Generic type 'Mock' requires between 0 and 1 type arguments" errors
  • Eliminated "Argument of type '{}' is not assignable to parameter of type 'never'" errors

Refactored

• Extracted duplicate sound selection logic into getSelectedSound() helper method in SoundManager.
• Simplified timer duration calculation using array indexing instead of if/else chain.
• Flattened icon selection conditions to reduce nesting in timer state management.
• Added TODO comment to revisit CDN URL duplication in sound management.
• Comprehensive test suite refactoring and optimization:
  • Enhanced test suite with comprehensive helper functions to reduce code duplication:
  • Added common-test-helpers.ts with shared mock setup utilities
  • Added plugin-test-helpers.ts for plugin-specific test patterns
  • Enhanced settings-test-helpers.ts with validation testing utilities
  • Broke down large test files into focused, maintainable modules:
  • Split settings-tab.test.ts into 3 specialized files (display, interactions, validation)
  • Split plugin.test.ts into 4 specialized files (commands, compatibility, lifecycle, settings-management)
  • Improved test code quality by extracting common patterns and reducing duplication across test suites
  • Fixed lint errors in test suite by adding proper ESLint disable comments for helper functions with internal assertions
  • Optimized test suite by removing redundant tests:
  • Eliminated 17 unnecessary tests (21.5% reduction) while maintaining coverage
  • Removed 2 fully redundant test files (settings/interactions.test.ts, plugin/settings-management.test.ts)
  • Consolidated overlapping timer state transition tests
  • Merged duplicate lifecycle and cleanup tests
  • Reduced test count from 79 to 62 tests across 10 files
  • Maintained >70% code coverage with significantly reduced maintenance burden

What's Changed

• Refactor tests into smaller files and fix timer bugs by @semanticdata in https://github.com/semanticdata/obsidian-pomodoro/pull/12

Full Changelog: https://github.com/semanticdata/obsidian-pomodoro/compare/1.6.0…1.6.1